Fixes for isLegalPrefix change #22241
Merged
+173
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
approved these changes
Jan 9, 2025
| @@ -768,6 +790,7 @@ class Inliner(val call: tpd.Tree)(using Context): | |||
| override def typedSelect(tree: untpd.Select, pt: Type)(using Context): Tree = { | |||
| val locked = ctx.typerState.ownedVars | |||
| val qual1 = typed(tree.qualifier, shallowSelectionProto(tree.name, pt, this, tree.nameSpan)) | |||
| selectionType(tree, qual1) // side-effect | |||
There was a problem hiding this comment.
It would be good to be more specific what side effect (error messages?, anything else?)
There was a problem hiding this comment.
It fixes the denotation of the hash-consed TermRef. So in Featureful[?]#toFeatures, selectionType will skolemize the prefix, find the denotation, and then set that denotation for the TermRef(Featureful[?], symbol toFeatures).
|
This should get in before the cutoff. |
|
Is there anything left to do with this changes? Would be great if we could confirm the regressions are fixed before the cutoff |
|
It was just an open question. We can merge and get an answer later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22062
Fixes #22068
Fixes #22070